Rust: Update legacy MaD models 3 #19946
Draft
+212
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
added
no-change-note-required
|
There's currently a large number of test changes caused by this PR (highlighted by CI). I think it would be prudent to get the first two PRs merged before attempting to address this. |
aibaars
reviewed
Jul 4, 2025
aibaars
reviewed
Jul 8, 2025
| - ["repo:https://github.com/hyperium/hyper-util:hyper-util", "<crate::client::legacy::Client>::get", "ReturnValue.Future", "remote", "manual"] | ||
| - ["repo:https://github.com/hyperium/hyper-util:hyper-util", "<crate::client::legacy::Client>::request", "ReturnValue.Future", "remote", "manual"] | ||
| - ["<hyper::client::conn::http1::SendRequest>::send_request", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "remote", "manual"] | ||
| - ["<hyper::client::conn::http2::SendRequest>::send_request", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "remote", "manual"] |
There was a problem hiding this comment.
The test runs show failures for sender.send_request() not being recognised as remote source. The model looks fine though. I expect the problem is a failure in the type inferencer. I think the following type annotation should make the test pass again:
- let (mut sender, conn) = hyper::client::conn::http1::handshake(io).await?;
+ let (sender, conn) = hyper::client::conn::http1::handshake(io).await?;
+ let mut sender: hyper::client::conn::http1::SendRequest<String> = sender;There was a problem hiding this comment.
Yep, it works better like that. I've pushed some updates, we'll see how the other tests look now.
Created #20004 to log the type inference issue here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update even more legacy MaD models to the new model format (continues from #19942 and should be independent of that).